Without this, newer versions of automake give a warning, and since -Werror is set, this is treated as an error. This can result in build failures such as: automake: warnings are treated as errors common/Makefile.am:4: warning: source file '$(srcdir)/generated_client_demarshallers.c' is in a subdirectory, common/Makefile.am:4: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. common/Makefile.am:4: warning: source file '$(srcdir)/generated_client_demarshallers1.c' is in a subdirectory, common/Makefile.am:4: but option 'subdir-objects' is disabled common/Makefile.am:4: warning: source file '$(srcdir)/generated_client_marshallers.c' is in a subdirectory, common/Makefile.am:4: but option 'subdir-objects' is disabled common/Makefile.am:4: warning: source file '$(srcdir)/generated_client_marshallers1.c' is in a subdirectory, common/Makefile.am:4: but option 'subdir-objects' is disabled common/Makefile.am:11: warning: source file '$(srcdir)/generated_server_demarshallers.c' is in a subdirectory, common/Makefile.am:11: but option 'subdir-objects' is disabled common/Makefile.am:11: warning: source file '$(srcdir)/generated_server_marshallers.c' is in a subdirectory, common/Makefile.am:11: but option 'subdir-objects' is disabled autoreconf: automake failed with exit status: 1 error: Bad exit status from /var/tmp/rpm-tmp.BsVXmS (%build) Fixes https://bugs.freedesktop.org/show_bug.cgi?id=67304 properly. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 98311bf..46558e2 100644 --- a/configure.ac +++ b/configure.ac @@ -13,7 +13,7 @@ AC_CONFIG_AUX_DIR([build-aux]) m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) # Checks for programs -AM_INIT_AUTOMAKE([1.11 dist-xz no-dist-gzip tar-ustar foreign -Wall -Werror]) +AM_INIT_AUTOMAKE([1.11 dist-xz no-dist-gzip tar-ustar foreign subdir-objects -Wall -Werror]) AM_MAINTAINER_MODE AM_SILENT_RULES([yes]) LT_INIT -- 2.4.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel