On Sat, 2014-12-06 at 00:14 +0200, Alon Levy wrote: > On 12/06/2014 12:00 AM, Jonathon Jongsma wrote: > > On Fri, 2014-12-05 at 23:41 +0200, Alon Levy wrote: > >> [snip] > >>> > >>> At the same time, I'm not sure mailing lists are the right tool for code > >>> review. It's difficult to track which patches have been reviewed and > >>> which haven't. > >> > >> http://patchwork.freedesktop.org/project/Spice/list/ can help, linked > >> from the wiki btw (http://www.spice-space.org/page/Main_Page) > >> > >> (not getting into this otherwise :) > >> > > > > Thanks, I had forgotten about that. I notice now that all patches listed > > on that site are in state "New". Is there a magical incantation we can > > insert into our review that will change the patch state to "Approved" or > > "Needs Work" or something? If so, can we start using this incantation > > rather than our traditional "ACK", so that patchwork will be able to > > track the true state of these patches? > > I don't know that magic, but it does sound handy. Hrm, after trawling the patchwork mailing list archives, it appears that it's not actually possible to change the patch state via email. The authors consider this to be insecure since anybody could change the review state: https://lists.ozlabs.org/pipermail/patchwork/2012-April/000700.html That's too bad since I think it makes it significantly less useful as a passive tool for tracking patches. However we could at least set up the provided git post-receive hook that sets a patch status to Accepted after it is pushed to the repository. _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel