----- Mail original ----- > On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote: > > > > > > ----- Original Message ----- > > > Message will be used by client for requesting an information about > > > a version of the agent running on the guest side. > > > --- > > > v2: > > > - removed 'type' field from VDAgentInformation > > > - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION > > > VDAgentInformation changed to VDAgentGuestVersion > > > - added VD_AGENT_CAP_GUEST_VERSION > > > > looks good; but I still worry about use fulness of this message. > > Having only the agent version is really a small part of what is > > the guest actually running, and it might be misleading (missing > > configure options, patches, dependencies etc) > > The sent data is a string, we can always stick more than a simple > version number in it. If we go that way, a more generic name would be > better though. > If this message is only meant for user display only (which I think it should), then it could be defined as free-form text containing various guest details, in which case I would also propose to rename GUEST_VERSION -> GUEST_INFOS. _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel