----- Original Message -----
> Message will be used by client for requesting an information about
> a version of the agent running on the guest side.
> ---
> v2:
> - removed 'type' field from VDAgentInformation
> - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION
> VDAgentInformation changed to VDAgentGuestVersion
> - added VD_AGENT_CAP_GUEST_VERSION
looks good; but I still worry about use fulness of this message.
Having only the agent version is really a small part of what is
the guest actually running, and it might be misleading (missing
configure options, patches, dependencies etc)
> ---
> spice/vd_agent.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/spice/vd_agent.h b/spice/vd_agent.h
> index 7464661..31356a8 100644
> --- a/spice/vd_agent.h
> +++ b/spice/vd_agent.h
> @@ -77,6 +77,7 @@ enum {
> VD_AGENT_FILE_XFER_DATA,
> VD_AGENT_CLIENT_DISCONNECTED,
> VD_AGENT_MAX_CLIPBOARD,
> + VD_AGENT_GUEST_VERSION,
> VD_AGENT_END_MESSAGE,
> };
>
> @@ -218,6 +219,7 @@ enum {
> VD_AGENT_CAP_GUEST_LINEEND_LF,
> VD_AGENT_CAP_GUEST_LINEEND_CRLF,
> VD_AGENT_CAP_MAX_CLIPBOARD,
> + VD_AGENT_CAP_GUEST_VERSION,
> VD_AGENT_END_CAP,
> };
>
> @@ -245,6 +247,10 @@ typedef struct SPICE_ATTR_PACKED
> VDAgentAnnounceCapabilities {
> #define VD_AGENT_SET_CAPABILITY(caps, index) \
> { (caps)[(index) / 32] |= (1 << ((index) % 32)); }
>
> +typedef struct SPICE_ATTR_PACKED VDAgentGuestVersion {
> + uint8_t data[0];
> +} VDAgentGuestVersion;
> +
> #include <spice/end-packed.h>
>
> #endif /* _H_VD_AGENT */
> --
> 1.9.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel