Re: [PATCH spice-protocol v2] Add agent information message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > Message will be used by client for requesting an information about
> > a version of the agent running on the guest side.
> > ---
> > v2:
> >  - removed 'type' field from VDAgentInformation
> >  - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION
> >    VDAgentInformation changed to VDAgentGuestVersion
> >  - added VD_AGENT_CAP_GUEST_VERSION
> 
> looks good; but I still worry about use fulness of this message.
> Having only the agent version is really a small part of what is
> the guest actually running, and it might be misleading (missing
> configure options, patches, dependencies etc)

The sent data is a string, we can always stick more than a simple
version number in it. If we go that way, a more generic name would be
better though.

Christophe

Attachment: pgpo3zyTtUt3d.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]