On Mon, Jun 11, 2012 at 07:58:24PM +0200, Hans de Goede wrote: > Hi, > > On 06/11/2012 04:45 PM, Jeremy White wrote: > >Forgive me if this is FAQ'd elsewhere, but I did not find it in a short > >hunt, and I'm curious. > > Documentation is not our strong point, help with that is greatly > appreciated :) > > >Who has commit access to the main trees, > > For all the repositories under http://cgit.freedesktop.org/spice/ > anyone who has a proven track record of being a team player and making > regular code contributions so far has been given direct commit / push > access. That currently means the entire Spice team @ Red Hat, and > Daniel P. Berrange have access (not sure if I'm missing someone ...) > > Note that since access is managed through a unix group, access to one > of them means access to all of them. > > > and how is the decision to > >commit made? > > For the above repositories in general the rule is send patches to > spice-devel, wait for review and revise on comments, or push on ack. While an ACK from another person with commit access is typically seen as the benchmark for pushing to master, this should not be discouraging any other person on this mailing list from adding their review feedback on patches. Code reviews are always welcome from any interested party who feels they can add useful feedback to a patch posting. Indeed, if you are aiming/hoping to gain commit rights in the future, doing code reviews is a good way to show off your skills & commitment to the project. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel