On Sat, Jul 22, 2017 at 02:26:25PM +0530, Allen wrote: > Sam/David, > > > >It is way better than the hardcoded values. > >If the vales have any sort of name in the sparc specs > >the values shall be prefixed with this. > >Otherwise something like > >CPU_ID_xxx > > > >And maybe add an intro comment like this: > >/* following CPU_ID_xxx constants are used to identify the > > * CPU type in the setup phase (see xxx.S) > >*/ > > > > Here's a quick diff. Let me know if this looks good to you guys. > I'll send out the patch. I have tested this on a T4. Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
