On Fri, Jul 21, 2017 at 02:51:59PM +0530, Allen wrote: > > Hi Sam, > > >>+++ b/arch/sparc/kernel/head_64.S > >>@@ -439,6 +439,9 @@ EXPORT_SYMBOL(sun4v_chip_type) > >> cmp %g2, '7' > >> be,pt %xcc, 5f > >> mov SUN4V_CHIP_SPARC_M7, %g4 > >>+ cmp %g2, '8' > >>+ be,pt %xcc, 5f > >>+ mov SUN4V_CHIP_SPARC_M8, %g4 > > > >Could we use this opportunity to create properly named > >constants for '7', '8', 'N' etc, rather than harcoding these > >in some assembler files. > >(Obviously in a separate patch). > > Would this work? It is way better than the hardcoded values. If the vales have any sort of name in the sparc specs the values shall be prefixed with this. Otherwise something like CPU_ID_xxx And maybe add an intro comment like this: /* following CPU_ID_xxx constants are used to identify the * CPU type in the setup phase (see xxx.S) */ (As character constants, but that part is obvious). Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
