Re: [PATCH 1/3] sparc64: recognize and support sparc M8 cpu type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Allen <allen.pais@xxxxxxxxxx>
Date: Fri, 21 Jul 2017 14:51:59 +0530

> 
> Hi Sam,
> 
>>> +++ b/arch/sparc/kernel/head_64.S
>>> @@ -439,6 +439,9 @@ EXPORT_SYMBOL(sun4v_chip_type)
>>>   	cmp	%g2, '7'
>>>   	be,pt	%xcc, 5f
>>>   	 mov	SUN4V_CHIP_SPARC_M7, %g4
>>> +	cmp	%g2, '8'
>>> +	be,pt	%xcc, 5f
>>> +	 mov	SUN4V_CHIP_SPARC_M8, %g4
>>
>> Could we use this opportunity to create properly named
>> constants for '7', '8', 'N' etc, rather than harcoding these
>> in some assembler files.
>> (Obviously in a separate patch).
> 
> Would this work?

That won't even boot.

You're changing an ASCII character '?' value into a raw
constant.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux