Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/20/2017 2:58 PM, David Miller wrote:
From: Vijay Kumar <vijay.ac.kumar@xxxxxxxxxx>
Date: Sat,  8 Jul 2017 14:23:44 -0600

diff --git a/arch/sparc/kernel/hvapi.c b/arch/sparc/kernel/hvapi.c
index 2677312..0b070d5 100644
--- a/arch/sparc/kernel/hvapi.c
+++ b/arch/sparc/kernel/hvapi.c
@@ -189,7 +189,7 @@ void __init sun4v_hvapi_init(void)
group = HV_GRP_CORE;
  	major = 1;
-	minor = 1;
+	minor = 6; /* CPU POKE */
  	if (sun4v_hvapi_register(group, major, &minor))
  		goto bad;
That CPU POKE comment will not stand the test of time, please remove it.

+	/* Use cpu poke to resume idle cpu if supported*/
Please put a space at the end of the comment and before the "*/"

+		/*cpu poke is registered. */
Please put a space at the beginning of the comment.

And you should decide which way you want to consistently write.
Either capitalize the first word and finish the sentence with
a '.', or don't.  Do it the same way each time.

Thanks.
Sure, I will fix these in v2.

Thanks,
-Vijay

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux