On Fri, Jan 13, 2012 at 03:15:45PM -0800, David Miller wrote: > From: Sam Ravnborg <sam@xxxxxxxxxxxx> > Date: Tue, 3 Jan 2012 21:45:16 +0100 > > > + /* Reserve all highmem in memblock - this may be nothing */ > > + memblock_reserve(highstart, memblock_end_of_DRAM() - highstart); > > Actually this calculation is going to be negative most of the time when > there is no highmem. And if it is in fact zero, memblock_reserve() has > a BUG check on that. > > I therefore think you'll need to guard this with a: > > if (memblock_end_of_DRAM() - highstart) > > test. Good catch - I had not seen this. > > Otherwise this patch so far looks great. Thanks! I will look at it further the coming weekend addressing your comments. Obviously I will adapt it to the now merged work of Tejun on memblock. My aim is to have my own box booting before I post next update. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
