Re: [WIP] sparc32: replace bootmem with memblock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Tue, 3 Jan 2012 21:45:16 +0100

> +	/* Reserve all highmem in memblock - this may be nothing */
> +	memblock_reserve(highstart, memblock_end_of_DRAM() - highstart);

Actually this calculation is going to be negative most of the time when
there is no highmem.  And if it is in fact zero, memblock_reserve() has
a BUG check on that.

I therefore think you'll need to guard this with a:

	if (memblock_end_of_DRAM() - highstart)

test.

Otherwise this patch so far looks great.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux