Jan Stary <hans@xxxxxxxx> writes: >> > (So far, zero people said "I am using it".) >> >> Only a tiny fraction of all sox users follow this mailing list. > > So where do you suggest one should ask this question instead? There is no way to contact all users. To remove a feature without angering users, you should first deprecate it and have it complain *loudly* for a couple of releases. If nobody pipes up saying they need it, it's likely safe to remove it, but even then a few users will probably come crawling out of the woodwork after it's finally gone. >> Just why do you think someone added the feature in the first place? My >> money is on someone needing it. > > Yes, most probably someone either needed or wanted that feature > years ago (see the Changelog) when it was added. Does anybody > still nedd it now? > > Similarly, SoX used to support ffmpeg, thus supporting > e.g. m4a audio. Then it was removed, luckily. But sure, > somebody must have wanted whan it was added. So what? > > I am not comparing ffmpeg to libmagic, I am just saying > the the fact that somebody once added it still does not > escape the question why it is there now? Is it still needed? > I think not, that;s all I'm saying. I don't know why ffmpeg support was added, nor why it was removed. It's really not comparable though. >> Unless it is broken or a burden to maintain, it should stay. You're not >> even the maintainer, so why do you care? > > You have a very strange attitude towards software. > I am not even the maintainer, so why do I care. Jesus. Nobody is asking you to maintain the libmagic support. >> >> Why do you hate this particular feature so badly? >> > >> > I don't hate it (or have any other sentiment towards it). >> > I just think it's unused cruft of questionable value, >> > and thus a candidate for removal. That's why I asked >> > if people are using it. (So far, no-one said yes.) >> >> You could say the same about almost every feature in sox. The vast >> majority of effects are very rarely used. > > The effects are audio signal processors. That's what SoX does. > Guessing the format of unknown files is not. That's what file(1) does. > So no, this stretched generalization of yours doesn't work either. "What sox does" also includes processing audio files of unknown format. >> > If I have an OGG file named *.wav, _that_ is the problem. If an internet >> > radio streams a FLAC stream named *.mp3, _that_ is the problem. >> > And using libmagic (or any format guessing for that matter) _in_SoX_ >> > is not a solution to it. Instead, find out what the format really is, >> > maybe using a tool designed for file format guessing such as file(1), >> > and fix _that_ first. "Fixing" it within SoX is imho a pollution of SoX. >> > That's my point. >> >> So you want to fix the internet. Good luck with that. > > And in closing, another meaningless strawman. > No, I don't want to "fix the internet", whatever you mean by that. I mean there are scores of files out there that are misnamed or otherwise without indication of format. Unless you can somehow fix every mistake on the internet, that's not going to change. -- Måns Rullgård ------------------------------------------------------------------------------ _______________________________________________ Sox-users mailing list Sox-users@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/sox-users
