On Fri, Jun 26 2015, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Thu, Jun 25, 2015 at 11:36:01AM +0200, Rasmus Villemoes wrote: >> On Thu, Jun 25 2015, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: >> >> > On Thu, Jun 25, 2015 at 12:05:24AM +0200, Rasmus Villemoes wrote: >> >> Hi Dan >> >> >> >> If and when you have time, can I get you to look at my misc_tweaks >> >> branch on github? >> >> <https://github.com/Villemoes/smatch/tree/misc_tweaks>. It is >> >> work-in-progress, but I'd like to hear if you hate it (or parts thereof) >> >> before doing more of the performance improvements. >> > >> > >> > "At least in my test, the fill_db_sql.pl part of create_db.sh went from >> > ~5 minutes to a bit under 3 minutes." >> > >> > Nice. My DB takes an hour to build... >> >> Yep, that's what I noticed, so I wanted to see if one could do something >> about it. Even 10% or 20% are probably worth it when we're talking this >> magnitude. It took me 123 minutes to build the database for an >> allmodconfig on an 8-core, 24 GB ram box. > > I tried doing a `smatch_data/db/create_db.sh -p=kernel warns.txt` and it > was way slower. :( I had to kill it after some hours. That's odd. What kind of hardware do you run this on? Anyway, I've redone that part, so now perl/DBI is back, but the solution is a little ugly. See the misc_tweaks2 branch on github. I just built the database from scratch for an allmodconfig kernel in 63 minutes, which is almost exactly twice as fast as yesterday. If this version is also slow for you something weird must be going on. Rasmus PS: Just noticed that you used warns.txt, which suggests that you used the result from an old build. I've changed the format of some of the output lines in (smatch_)warns.txt, so you need to build the kernel from scratch. PPS: When you say "My DB takes an hour to build", is that the create_db.sh part, or is it the time for an entire build_kernel_data.sh run? -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
