On Thu, Feb 27, 2020 at 3:11 PM William Roberts <bill.c.roberts@xxxxxxxxx> wrote: > > <snip> > > > The hidden_def/hidden_proto stuff originally came from Ulrich Drepper, > > > glibc maintainer at the time, to eliminate unnecessary runtime > > > relocations and PLT entries being used for local symbols. Per the > > > comments in https://github.com/SELinuxProject/selinux/issues/204, > > > these might not be needed anymore and are breaking building with LTO. > > > Willing to get rid of them if it doesn't produce a significant > > > regression. > > I guess that's my major question, how do we determine this is a regression? > Obviously a functional break is self explanatory. The original statistics used to justify it were generated by the relinfo.pl script available from https://www.akkadia.org/drepper/relinfo.pl.
