I went through and annotated deprecated routines we have in
libselinux that are mentioned to be deprecated either in code
comments and/or manpages.
External users, when compiling will see a warning similair to some
sample output:
a.c: In function ‘main’:
a.c:18:2: warning: ‘foo’ is deprecated: foo bar msg [-Wdeprecated-declarations]
foo();
^~~
a.c:5:5: note: declared here
int foo(void) {
^~~
a.c:19:2: warning: ‘boo’ is deprecated [-Wdeprecated-declarations]
boo();
^~~
a.c:11:5: note: declared here
int boo(void) {
The annoying part is internal users of the routines. We could always make
a v2 version of the function for internal callers, and leave the old
interfaces intact to work around the warnings, or just pragma them out.
This series pragma's them out.
diagnostic push has been supported since GCC v4.6. Earlier versions will
warn on this, and the sideffect is that the diagnostic ignored pragma
will be valid for the rest of the file. Clang has similair support thats
been around *at least* since clang 6.0.
[PATCH 01/17] security_load_booleans: update return comment
[PATCH 02/17] selinux_booleans_path: annotate deprecated
[PATCH 03/17] selinux_booleans_path: annotate deprecated
[PATCH 04/17] selinux_users_path: annotate deprecated
[PATCH 05/17] rpm_execcon: annotate deprecated
[PATCH 06/17] sidget: annotate deprecated
[PATCH 07/17] sidput: annotate deprecated
[PATCH 08/17] checkPasswdAccess: annotate deprecated
[PATCH 09/17] matchpathcon_init: annotate deprecated
[PATCH 10/17] matchpathcon_fini: annotate deprecated
[PATCH 11/17] matchpathcon: annotate deprecated
[PATCH 12/17] avc_init: annotate deprecated
[PATCH 13/17] src/selinux_internal.h: fix hidden_proto indents
[PATCH 14/17] selinux_internal.h: disable warnings on deprecated
[PATCH 15/17] avc_open: mark allowed use of avc_init
[PATCH 16/17] src/matchpathcon: allow use of deprecated funcs
[PATCH 17/17] utils/matchpathcon: allow use of deprecated funcs
