<snip> > > The hidden_def/hidden_proto stuff originally came from Ulrich Drepper, > > glibc maintainer at the time, to eliminate unnecessary runtime > > relocations and PLT entries being used for local symbols. Per the > > comments in https://github.com/SELinuxProject/selinux/issues/204, > > these might not be needed anymore and are breaking building with LTO. > > Willing to get rid of them if it doesn't produce a significant > > regression. I guess that's my major question, how do we determine this is a regression? Obviously a functional break is self explanatory. > > Ulrich, could you help us understand the macros you proposed to add to > the SELinux libraries (probably a very long time ago)? Specifically, > we are talking about those defined in "dso.h" header files such as > this one [1]. See also GH issue 204 [2] for related discussion. > > Thanks, > > [1] https://github.com/SELinuxProject/selinux/blob/master/libselinux/src/dso.h > [2] https://github.com/SELinuxProject/selinux/issues/204 > > -- > Ondrej Mosnacek <omosnace at redhat dot com> > Software Engineer, Security Technologies > Red Hat, Inc. >
