On 6/23/23 11:03?AM, Song Liu wrote: > > >> On Jun 23, 2023, at 8:41 AM, Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> On 6/23/23 9:16?AM, Jens Axboe wrote: >>>> I will prepare another PR with just fixes. >>>> >>>> Christoph, >>>> >>>> Please let me know if you need set #1 (deprecate file bitmap) to >>>> unblock other work. Otherwise, we will delay it until 6.6. >>> >>> I've done a for-6.5/block-late and put your stuff there, but it can be >>> dropped very easily. It doesn't really matter if Christoph's stuff can >>> get pushed, it's still a lot of commits late. So regardless of that, the >>> only real difference with a new PR would be that we'd drop some bits. >>> It'd still go into a late branch, as it is indeed late. >> >> On second thought, yes let's go your suggested route. Make a branch with >> JUST the fixes, and send them my way. Anything else will have to wait >> for 6.6 at this point. I'll drop my late branch for now. > > Sounds good! Here is the updated pull request with only minor fixes. > Three of the fixes are for patches in the for-6.5/block branch: > > - md: use mddev->external to select holder in export_rdev() > - md/raid1-10: fix casting from randomized structure in raid1_submit_write() > - md: fix 'delete_mutex' deadlock Thanks, added to the for-6.5/block-late branch. -- Jens Axboe