Re: [PATCH 08/34] md: don't initilize statics/globals to 0/false [ERROR]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Heinz,


Thank you for your patch.

Am 06.03.23 um 22:27 schrieb heinzm@xxxxxxxxxx:
From: Heinz Mauelshagen <heinzm@xxxxxxxxxx>

There is a small typo in the commit message summary: initi*a*lize.

Signed-off-by: heinzm <heinzm@xxxxxxxxxx>

Please also use the full name in the Signed-off-by line.

---
  drivers/md/md.c    | 2 +-
  drivers/md/raid0.c | 2 +-
  drivers/md/raid5.c | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index e6ff0da6ebb6..9dc1df40c52d 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5563,7 +5563,7 @@ static struct kobj_type md_ktype = {
  	.default_groups	= md_attr_groups,
  };
-int mdp_major = 0;
+int mdp_major;
static void mddev_delayed_delete(struct work_struct *ws)
  {
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index 582457cea439..11b9815f153d 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -19,7 +19,7 @@
  #include "raid0.h"
  #include "raid5.h"
-static int default_layout = 0;
+static int default_layout;
  module_param(default_layout, int, 0644);
#define UNSUPPORTED_MDDEV_FLAGS \
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 00151c850a35..d0b6a97200fa 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -64,7 +64,7 @@
#define RAID5_MAX_REQ_STRIPES 256 -static bool devices_handle_discard_safely = false;
+static bool devices_handle_discard_safely;
  module_param(devices_handle_discard_safely, bool, 0644);
  MODULE_PARM_DESC(devices_handle_discard_safely,
  		 "Set to Y if all devices in each array reliably return zeroes on reads from discarded regions");

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux