Dear Heinz,
Thank you for your patch.
Am 06.03.23 um 22:27 schrieb heinzm@xxxxxxxxxx:
From: Heinz Mauelshagen <heinzm@xxxxxxxxxx>
I’d prefer statements as commit message summary, that means adding a
verb (in imperative mood):
md: Let else follow close curly brace [ERROR]
Signed-off-by: heinzm <heinzm@xxxxxxxxxx>
---
drivers/md/md-cluster.c | 3 +--
drivers/md/md.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
index 9bcf816b80a1..760b3ba37854 100644
--- a/drivers/md/md-cluster.c
+++ b/drivers/md/md-cluster.c
@@ -548,8 +548,7 @@ static void process_remove_disk(struct mddev *mddev, struct cluster_msg *msg)
set_bit(ClusterRemove, &rdev->flags);
set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
md_wakeup_thread(mddev->thread);
- }
- else
+ } else
pr_warn("%s: %d Could not find disk(%d) to REMOVE\n",
__func__, __LINE__, le32_to_cpu(msg->raid_slot));
rcu_read_unlock();
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9dc1df40c52d..ff4699babdd6 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9694,8 +9694,7 @@ static void check_sb_changes(struct mddev *mddev, struct md_rdev *rdev)
rdev2->bdev);
md_kick_rdev_from_array(rdev2);
continue;
- }
- else
+ } else
clear_bit(Candidate, &rdev2->flags);
}
Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Kind regards,
Paul
