Dear Markus,
Am 16.11.21 um 10:44 schrieb Markus Hochholdinger:
Am Dienstag, 16. November 2021, 10:24:17 CET schrieb Paul Menzel:
[…]
Am 12.11.21 um 15:28 schrieb markus@xxxxxxxxxxxxxxxxx:
From: Markus Hochholdinger <markus@xxxxxxxxxxxxxxxxx>
The superblock of version 1.0 doesn't get moved to the new position on a
device size change. This leads to a rdev without a superblock on a known
position, the raid can't be re-assembled.
Fixes: commit d9c0fa509eaf ("md: fix max sectors calculation for super
1.0")
I think it’s common to not write *commit* in there, but just the short
hash. `scripts/checkpatch.pl` does not mention that, but it mentions:
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 7 lines checked
I'm sorry, this was my first patch request against the linux kernel.
Awesome. We all started with that.
Within https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
tree/Documentation/process/submitting-patches.rst I read to sign off a patch if
it is from me, but the line was there before. So I thought I don't have to
sign it.
No, even reverts have to be signed off.
Should I do the patch request again with Signed-off information?
Yes, please do, and maybe amend the commit message, to mention, that the
line was removed by mistake, and is added back.
You can create a v2 easily with the `git send-email` switch below:
-v <n>, --reroll-count=<n>
You can also add the Reviewed-by lines you already got.
[…]
Kind regards,
Paul
