Dear Markus,
Thank you for your patch.
Am 12.11.21 um 15:28 schrieb markus@xxxxxxxxxxxxxxxxx:
From: Markus Hochholdinger <markus@xxxxxxxxxxxxxxxxx>
The superblock of version 1.0 doesn't get moved to the new position on a
device size change. This leads to a rdev without a superblock on a known
position, the raid can't be re-assembled.
Fixes: commit d9c0fa509eaf ("md: fix max sectors calculation for super 1.0")
I think it’s common to not write *commit* in there, but just the short
hash. `scripts/checkpatch.pl` does not mention that, but it mentions:
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 7 lines checked
---
drivers/md/md.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 6c0c3d0d905a..ad968cfc883d 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2193,6 +2193,7 @@ super_1_rdev_size_change(struct md_rdev *rdev, sector_t num_sectors)
if (!num_sectors || num_sectors > max_sectors)
num_sectors = max_sectors;
+ rdev->sb_start = sb_start;
}
sb = page_address(rdev->sb_page);
sb->data_size = cpu_to_le64(num_sectors);
Kind regards,
Paul
