Re: [md PATCH 10/34] md/raid5: unify stripe_head_state and r6_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011-07-22 (금), 14:54 +0900, Namhyung Kim:
> 2011-07-22 (금), 15:37 +1000, NeilBrown:
> From 74721b68b4cf8d4845aa9efa3daf99247a611b70 Mon Sep 17 00:00:00 2001
> > From: NeilBrown <neilb@xxxxxxx>
> > Date: Fri, 22 Jul 2011 15:29:38 +1000
> > Subject: [PATCH] md/raid5: Remove stripe_head_state arg from handle_stripe_expansion.
> > 
> > This arg is only used to differentiate between RAID5 and RAID6 but
> > that is not needed.  For RAID5, raid5_compute_sector will set qd_idx
> > to "~0" so j with certainly not equals qd_idx, so there is no need
> > for a guard on that condition.
> > 
> > So remove the guard and remove the arg from the declaration and
> > callers of handle_stripe_expansion.
> > 
> > Signed-off-by: NeilBrown <neilb@xxxxxxx>
> 
> Looks good to me, thanks!
> 

And please feel free to add this in case you need it :)

Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxx>



-- 
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux