On Wed, 20 Jul 2011 19:57:03 +0200 Piergiorgio Sartor <piergiorgio.sartor@xxxxxxxx> wrote: > Hi Neil, > > sorry for the very late answer. > > On 05/16/2011 12:08 PM, NeilBrown wrote: > > On Sun, 15 May 2011 23:15:15 +0200 Piergiorgio Sartor > > <piergiorgio.sartor@xxxxxxxx> wrote: > > > >> Hi Neil, > >> > >> reminder for the suspend patch. > >> > >> Thank you so much for the code review. > >> > >> I modified it in order to fix, hopefully, all the flaws. > >> > >> New patch attached below. > >> > >> Please note that "sigblock()" cannot be used, since it is > >> declared, at least on my system, as "deprecated". > >> Furthermore, I noticed that "Grow.c" is not checking the > >> return value of "sysfs_set_num()" while suspending the > >> array, maybe you'll need to look at this. > >> > >> Finally, please check the new patch too, while I can > >> confirm the software is doing what is supposed to do, > >> I still need support in order to confirm the suspend > >> and resume code. > >> > >> Thanks again for your help, again let me know what > >> is the next expected step. > > > > That all looks fine thank. I've applied it and pushed it out. > > > > I'm not sure what you mean exactly by the 'next expected step'... > > Well, is there anything than should be done, like > documentation or code cleanup? > > At the moment, it seems to me, the check itself it is > fine, maybe performance is not at best (anyone wants > to help, here?). > > So, I was thinking about the "repair" process, that is > fixing the chunks which seem corrupted, instead of just > the parity. > > Before I go that way, I would like to close pending issues, > if any, with the actual software. Very sensible - thanks. I haven't actually used it or tested it at all so I don't know of any issues in that regard. I agree with an earlier reply that a man-page would be a good idea. You could start by looking at "mdadm.8.in" and basing your man page on that. It doesn't have to be very long - just explain what it does and how to use it, and maybe how to interpret the results. Often writing a man page is enough to flush out any serious usability issues - if you find it hard to explain how to use it, it is probably because it is hard to use :-) If you aren't familiar with the troff -man markup language don't let it worry you - I am happy to fix up any markup issues before including it. It might be good to create a test script too - something that can go in the tests/ directory would be ideal. e.g. create and initialise a RAID6, deliberately corrupt one block, then run your program an check that it reports the right thing. Probably corrupt a different blocks (randomly?) on each device and test that it reports all of the errors correctly... something like that. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
