On Tue, 01 Mar 2011 15:56:50 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote:
> When reshape is continued backup_file is required for user data safety.
> Grow_continue() has to verify if any file name is passed in.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx>
> ---
>
> Grow.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index 47b8809..1470a91 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -3332,6 +3332,11 @@ int Grow_continue(int mdfd, struct supertype *st, struct mdinfo *info,
> char *container = NULL;
> int err;
>
> + if (backup_file == NULL) {
> + fprintf(stderr, Name ": Backup file name has to be specified "
> + "for reshape continuation.\n");
> + return 1;
> + }
> if (!st->ss->external) {
> err = sysfs_set_str(info, NULL, "array_state", "readonly");
> if (err)
reshape_array already performs checks to ensure that backup_file is set when
needed - it isn't always needed.
Is there some reason those checks are not enough?
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
