On Mon, 28 Feb 2011 16:06:55 +0100 Adam Kwolek <adam.kwolek@xxxxxxxxx> wrote: > This is first part of reshape continuation. This patch series makes (mainly) some changes to Grow_continue() > for use for reshape continuation during array assembling. > > It runs reshape_array() in background (for container operation it should be also ok, as we can have only one > metadata marked for reshape at the time). This is the 4th patch I assume... That fork should not be needed. We pass '0' as the 'forked' parameter to 'reshape_array', so reshape_array will fork and continue in the background. Why does Grow_continue need to fork as well?? > For external metadata reshape_array requires container name parameter. Yep. > > For reshape invoked from assembly reshape_array cannot start reshape (this would push md to call i.e. start_reshape > vector from personality). Staring reshape is based on run() mechanism in md so reshape_array should not configure or start reshape. I think you just need to change the call: - err = start_reshape(sra, (info->reshape_active && !st->ss->external)); to + err = start_reshape(sra, info->reshape_active); to fix that, don't you? > It should monitor check-pointing only. > > > BR > Adam > > > --- > > Adam Kwolek (5): > FIX: Do not configure and start, already started reshape > FIX: Continue reshape in the background The above 2 I have not applied. > FIX: Set readonly state in Grow_continue() when necessary > FIX: Pass container name to reshape array for external meta data > FIX: Spelling error in dprintf output There 3 I have applied. Thanks, NeilBrown > > > Grow.c | 53 ++++++++++++++++++++++++++++++++++++++++------------- > 1 files changed, 40 insertions(+), 13 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
