On Tue, 22 Feb 2011 17:42:14 +0100 Jan Ceuleers <jan.ceuleers@xxxxxxxxxxxx> wrote: > On 22/02/11 01:50, NeilBrown wrote: > > With the patch, the rescan is only performed when needed and so there > > are no races. > > Neil, > > If I've properly understood your commit message you are reducing the > frequency of the rescans, but they can still occur. I submit that this > merely reduces the probability but does not remove the possibility of > races with udev. > > If my interpretation is correct, then is this something that should be > fixed (to remove the possibility of races altogether), or merely documented? > > Thanks, Jan Thanks for reviewing the code!! The patch should reduce the frequency of rescans to just those times when it is actually needed. i.e. when the array data first becomes available, and when it stops being available. So it will only happen as a direct result of an administrative action. Previously it could happen at arbitrary times based on open /close/unlink patterns. So it isn't really "reducing the frequency" so much as "making it happen only at well defined times, not arbitrary times". So this does remove any possibility of races. Thanks, NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
