Re: [PATCH 2/2] IMSM: do not rebuild the array if a non-redundant sub-array with failed disks is present

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




This seems to imply that there are only ever at most 2 volumes in a
container.  Is that really true?  The rest of the code seems to assume
that
there could be several.


There are at most two sub-array in one array.

Empirically to date yes, but...

This is an arbitrary restriction imposed by the orom, it could be changed in future versions and it is not enforced when setting the IMSM_NO_PLATFORM variable.

When coding for "more than 1" it is not much more effort to code for "infinite". This approach helped find bugs in the implementation/usage of reserve_space() that would not have triggered if the tests (tests/08imsm-overlap) were hardcoded for at most 2 arrays.

So the implementation should handle the case when imsm_orom.vpa > 2 or IMSM_NO_PLATFORM == 1.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux