Re: RAID0 - unitialised zone->dev_start for zone[0]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



NeilBrown wrote:
On Thu, May 14, 2009 3:08 am, SandeepKsinha wrote:
Hi Neil,


[22:33:46 sinhas]$ diff raid0.c raid0.c.orig

Always, always, always use "diff -u".  It provides context
so the diff is much easier to read.

160d159
<       zone->dev_start = 0;
[/usr/src/linux-2.6.29/drivers/md]
[22:33:59 sinhas]$

I see this piece of code missing and being used later.
Not very sure of the code flow, but still as part of defensive
programming.

Am i missing something?

conf->strip_zone is allocated with kzalloc, so all values are
initialised to 0.

To prevent future unnecessary analysis of this section, perhaps a comment instead of code would be appropriate?


--
bill davidsen <davidsen@xxxxxxx>
 CTO TMR Associates, Inc

"You are disgraced professional losers. And by the way, give us our money back."
   - Representative Earl Pomeroy,  Democrat of North Dakota
on the A.I.G. executives who were paid bonuses  after a federal bailout.


--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux