Re: [PATCH] md: fix multipath oops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08:57, Neil Brown wrote:
> 2/ You have introduced a subtle semantic change.  If ->sys_action is
>    NULL, we no longer clear MD_RECOVERY_RECOVER.  I suspect this isn't
>    actually an error in practice, but I think it is still the wrong
>    way around to do the tests.
>    I have
> 			if (test_and_clear_bit(MD_RECOVERY_RECOVER,
> 					       &mddev->recovery))
> 				if (mddev->sysfs_action)
> 					sysfs_notify_dirent(mddev->sysfs_action);

Yes, I agree that's more reasonable.

Thanks
Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux