On Thursday May 1, dan.j.williams@xxxxxxxxx wrote: > > [ thinking out loud here to make sure we are on the same page ] > > I had to convince myself that it is still holding off writes while > MD_CHANGE_DEVS is set. And yes, MD_CHANGE_PENDING is not cleared > until after MD_CHANGE_DEVS is handled. So, the mddev->flags==0 test > was indeed more restrictive than it needed to be. Adding the > unqualified wait_event() to md_allow_write() also makes sense since it > is needed in the 'external' case and should be a nop in the > '!external' case since those bits are cleared in md_update_sb(). > > Simple test confirms this is working as expected. Good, thanks. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html