On Tuesday April 29, dan.j.williams@xxxxxxxxx wrote:
> This additional notification to 'array_state' is needed to allow the monitor
> application to learn about stop events via sysfs. The
> sysfs_notify("sync_action") call that comes at the end of do_md_stop() (via
> md_new_event) is insufficient since the 'sync_action' attribute has been
> removed by this point.
>
> (Seems like a sysfs-notify-on-removal patch is a better fix. Currently removal
> updates the event count but does not wake up waiters)
>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
Thanks.
Again, drop the "if (mddev->external)". It isn't needed (I have made
this change).
NeilBrown
>
> drivers/md/md.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index ad53035..606c8ee 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3693,6 +3693,9 @@ static int do_md_stop(mddev_t * mddev, int mode)
>
> module_put(mddev->pers->owner);
> mddev->pers = NULL;
> + /* tell userspace to handle 'inactive' */
> + if (mddev->external)
> + sysfs_notify(&mddev->kobj, NULL, "array_state");
>
> set_capacity(disk, 0);
> mddev->changed = 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
