On Wednesday October 10, iusty@xxxxxxxxx wrote:
> On Mon, Sep 10, 2007 at 06:51:14PM +0200, Iustin Pop wrote:
> > The 'degraded' attribute is useful to quickly determine if the array is
> > degraded, instead of parsing 'mdadm -D' output or relying on the other
> > techniques (number of working devices against number of defined devices, etc.).
> > The md code already keeps track of this attribute, so it's useful to export it.
> >
> > Signed-off-by: Iustin Pop <iusty@xxxxxxxxx>
> > ---
> > Note: I sent this back in January and it people agreed it was a good
> > idea. However, it has not been picked up. So here I resend it again.
>
> Ping? Neil, could you spare a few moments to look at this? (and sorry for
> bothering you)
Yeh.... thanks for your patience. September was not a good time for
getting my attention.
Yes, I think this is both sensible and useful.
I might just change......
> > @@ -2842,6 +2842,12 @@ sync_max_store(mddev_t *mddev, const char *buf, size_t len)
> > static struct md_sysfs_entry md_sync_max =
> > __ATTR(sync_speed_max, S_IRUGO|S_IWUSR, sync_max_show, sync_max_store);
> >
> > +static ssize_t
> > +degraded_show(mddev_t *mddev, char *page)
> > +{
> > + return sprintf(page, "%i\n", mddev->degraded);
> > +}
... the %i to a %d though. At first I thought it was a typo, but
then checked the man page and discovered that %d and %i both mean the
same thing (so why support them both I wonder).
Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
