Re: [PATCH] md - 1 of 12 - Missing mddev_put in md resync code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Neil,

Are these patches safe to apply against 2.4 kernels?

It looks like one or more of these might reduce the chances of the
kernel oops I experience on occasion when manipulating arrays.

Also, this appears to change some of the way rebuilds are done, and am
interested to see if this impacts some of the rebuild performance issues
I've been seeing.

Thanks!

Sean.


> Here are 12 patches for md/raid in 2.5.latest.
> As well as some tidy-ups and bug fixes they include:
> 
>   /proc/mdstat as a seq_file
>   "safe_mode" is always on, but normally with a 20msec delay. 
>     This means that if there are no writes for 20msec, the superblock
>     is marked 'clean' so that an unclean shutdown does not cause
>     a complete resync.
>   New super-block format (no user-level code to support this yet).
> 
> NeilBrown
> 
> ### Comments for ChangeSet
> 
> Whenever a ITERATE_MDDEV loop is exitted abnormally
> we need to mddev_put the current mddev.  There was
> one point in md_do_sync where we didn't so use counts
> became wrong.
> 
>  ----------- Diffstat output ------------
>  ./drivers/md/md.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff ./drivers/md/md.c~current~ ./drivers/md/md.c
> --- ./drivers/md/md.c~current~	2003-03-12 09:31:38.000000000 +1100
> +++ ./drivers/md/md.c	2003-03-12 09:31:38.000000000 +1100
> @@ -2920,8 +2920,10 @@ static void md_do_sync(void *data)
>  					goto skip;
>  				}
>  			}
> -			if (mddev->curr_resync == 1)
> +			if (mddev->curr_resync == 1) {
> +				mddev_put(mddev2);
>  				break;
> +			}
>  		}
>  	} while (mddev->curr_resync < 2);
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 

Sean C. Kormilo, STORM Software Architect, Nortel Networks
              email: skormilo@nortelnetworks.com
  

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux