Re: RAID 1+0 makes BUG in raid1.c, but 0+1 works?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday December 25, smcdermott@questra.com wrote:
> 
> is there something I'm doing wrong or is this a bug? Should I not be
> using RAID1+0 ? I just tried it with RAID0+1 instead and it seems to
> work fine (although it's somewhat slower than I expected, and initial
> sync goes 250K/s for some reason until I turn up the minimum).  This
> makes no sense to me as I thought that RAID devices were a block-level
> abstraction...so why would 0+1 work but not 1+0 ?? I really dislike the
> additional probability of second-disk failure in RAID0+1 over RAID1+0,
> and the ridiculous resync times, and I don't like the slow write speed
> of RAID5.

It is a bug.  Arguably, the bug is that the test and BUG() call are
wrong, but  the patch below is probably the perferred fix in a stable
kernel.

I always recommend raid1 or raid5 at the bottom, and raid0/linear/lvm
on top of that.

NeilBrown

 ----------- Diffstat output ------------
 ./drivers/md/md.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~	2002-12-17 15:20:57.000000000 +1100
+++ ./drivers/md/md.c	2003-01-02 11:05:20.000000000 +1100
@@ -489,7 +489,7 @@ static int sync_page_io(kdev_t dev, unsi
 	init_buffer(&bh, bh_complete, &event);
 	bh.b_rdev = dev;
 	bh.b_rsector = sector;
-	bh.b_state	= (1 << BH_Req) | (1 << BH_Mapped);
+	bh.b_state	= (1 << BH_Req) | (1 << BH_Mapped) | (1 << BH_Locked);
 	bh.b_size = size;
 	bh.b_page = page;
 	bh.b_reqnext = NULL;
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux