On Fri, 2019-10-18 at 15:01 +0200, Hyperion wrote: > Yes !!! for the module argument ! (just a boolean is needed). > > Which module ? (module-bluez5-device ?). Users load only module-bluetooth-discover, so the module argument has to be added to that module. module-bluetooth-discover in turn loads module-bluez5-discover, and the module argument needs to be added there too. Finally, module-bluez5-discover loads module-bluez5-device, which is the place where the option is actually used. The module argument needs to be added to all three modules. By the way, most technical mailing lists, including this one, prefer the interleaved reply style: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style -- Tanu > JP > > 18.10.2019, 14:52, "Hyperion" <h1p8r10n@xxxxxxxxxx>: > > That's Why I proposed to set the config switch to "legacy max > > negotiated bitpool" (current code) by default, and let the user > > decide if he/she wants to activate the "XQ max negociated bitpool" > > (my patch). > > > > This way it's less likely to cause regressions than Pali's "forced > > bitpool" XQ modes : by default PA behaves like current version. > > > > And it doesn't rely on future Bluez features. > > > > Jp > > > > 14:29, 18 octobre 2019, "Tanu Kaskinen" <tanuk@xxxxxx>: > > > On Thu, 2019-10-17 at 15:34 +0200, Hyperion wrote: > > > > Regression would mean that some devices can't connect anymore : this > > > > won't happen if a workaround is provided, and this workaround won't > > > > be used often. > > > > > > > > Most (99% ?) of the devices will work correctly with my patch (many > > > > of them in XQ mode, and some in legacy mode because they will fall > > > > back to legacy bitpool during negociation) > > > > > > > > The remaining (1% ?) : will need a simple boolean swicth in one of > > > > the PA config files to restrict negociation to legacy bitpool (a > > > > module option ? or daemon.conf ?). > > > > > > > > I think it's really "simple", efficient, and not dependent of any > > > > upcoming Bluez feature. > > > > > > > > "The complex solution is always the best until one find a simpler one" > > > > > > I don't know the number of users who use bluetooth headsets with > > > PulseAudio, but even just 1% regression rate can mean quite a few > > > unhappy users. When your headset suddenly stops working, it's not > > > trivial to figure out that you may need to pass a special argument to > > > module-bluetooth-discover in order to make it work again. > > > > > > It would be better to have a module argument to enable the XQ settings. > > > > > > -- > > > Tanu > > > > > > https://www.patreon.com/tanuk > > > https://liberapay.com/tanuk _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
