On Tue, 2016-05-03 at 18:26 +0530, arun at accosted.net wrote: > -pa_modargs *pa_modargs_new(const char *args, const char* const* valid_keys) { > +static int pa_modargs_parse(pa_modargs *ma, const char *args, const char* const* valid_keys, bool ignore_dupes) { Private functions shouldn't have pa_ prefix. Looks good otherwise. I fixed this issue and pushed to next. --Â Tanu