[PATCH] Add HDMI 5.1 and 7.1 profiles to default.conf as well

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2014-07-30 12:34, Alexander E. Patrakov wrote:
> 2014-07-30 16:31 GMT+06:00 David Henningsson <david.henningsson at canonical.com>:
>>
>>
>> On 2014-07-30 11:59, Alexander E. Patrakov wrote:
>>> Due to these complications, I don't think that the entire "include"
>>> idea makes sense. I will try an alternative approach - a shell script
>>> that writes the conf files that share the common parts.
>>
>>
>> Since we're planning to merge extra-hdmi.conf with default.conf (right?),
>> and force-speaker*.conf is probably going away at some not too distant
>> future, we're left with default.conf only.
>>
>> So common parts between what files...?
>
> I am going to generate default.conf and force-speaker*.conf, with the
> HDMI part merged into both. Thats because force-speaker* are not going
> away today, according to Tanu.
>
> And even then, the shell script makes sense in order to avoid
> copy-pasting the same HDMI-related things 8 times.

If you want to make a shell script, run it locally, and turn the result 
into a patch, that's your business. If you want to make the shell script 
part of your patch, I think that's a bad idea - the disadvantages of the 
additional complexity weighs heavier than the benefit of less copy-paste.

Also, I don't think force-speaker*.conf ever needs more than first HDMI 
set (i e hdmi:%f,0 in stereo, 5.1 and 7.1).
Unless you have an alsa-info counterexample?

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux