On 2014-07-30 11:59, Alexander E. Patrakov wrote: > 2014-07-27 17:24 GMT+06:00 Tanu Kaskinen <tanu.kaskinen at linux.intel.com>: >> On Tue, 2014-07-22 at 15:11 +0200, David Henningsson wrote: >>> >>> On 2014-07-13 16:07, Tanu Kaskinen wrote: >>>> If they're added to default.conf, they should be added to >>>> extra-hdmi.conf (it only has 5.1), force-speaker.conf and >>>> force-speaker-and-int-mic.conf too. And before you say anything, yes, >>>> this duplication is bad, feel free to fix it. I believe it would work if >>>> the other files would include default.conf, the syntax is >>>> >>>> .include default.conf >>> >>> Slightly off-topic: >>> >>> Not sure it would work for force-speaker.conf and >>> force-speaker-and-int-mic.conf (e g analog-stereo would be present in >>> both, and they're different), and I didn't know about this syntax feature. >> >> You're right, default.conf can't be included as is. We could have a >> common.conf that contains the parts that are the same in every profile >> set. analog-stereo would not be included in common.conf. >> >>> Anyway, these profile files are only needed for Ubuntu 12.04 3.2 kernel >>> and the 3.4 LTS kernel. We could consider removing that workaround at >>> some time... >> >> Oh, ok, I didn't know they're unnecessary on newer kernels. Yes, we >> should drop them at some point, but I guess now is not the time. > > Due to these complications, I don't think that the entire "include" > idea makes sense. I will try an alternative approach - a shell script > that writes the conf files that share the common parts. Since we're planning to merge extra-hdmi.conf with default.conf (right?), and force-speaker*.conf is probably going away at some not too distant future, we're left with default.conf only. So common parts between what files...? -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
