On Sat, 2013-01-05 at 12:41 +0800, Paul Meng wrote:
> Hi Tanu Kaskinen,
>
>
> I rewrote the patch by following your feedback.
> I kept
> "pa_operation_new_with_state_callback" ("pa_operation_new_with_cancel_callback" previously) refactoring as the same for a while because the argument favonia provided.
> If you insist that we should remove
> pa_operation_new_with_state_callback,
> I will send another patch with that removed.
> Thanks
Thank you for the patch. I still think that
pa_operation_new_with_state_callback() should be removed. I don't think
the functionality that it offers would get used any time soon. (I'm not
really convinced that it would be a good idea to have it anyway, even if
maintaining backward compatibility wasn't a problem. The vast majority
of applications will never need a cancel callback, so let's not bother
them with that by adding another callback parameter to each function
that returns an operation object.)
The documentation for pa_operation_set_state_callback() says "since
3.0", while it should be 4.0.
Please send patches either with "git send-email", or as an attachment
formatted with "git format-patch". The patch that you sent in the
message body has wrapped lines, so it doesn't apply. Patches generated
with the git tools contain proper attribution and commit message, and
don't require any copy-pasting from my part.
--
Tanu
