On Fri, Jan 4, 2013 at 7:50 AM, Tanu Kaskinen <tanuk at iki.fi> wrote: > Ok, would you be willing to write an updated patch? I'm CC'ing one of my teammates who might be able to do it now. > Some feedback about the first version: > > * It would be better to call the callback from operation_set_state > rather than from context_unlink(). That's probably true. We'll look at it. Thanks. > * pa_operation_new_with_cancel_callback() seems unnecessary. There's no > need to initialize the callback to anything else than NULL when creating > a new operation object. This is indeed unnecessary under the current practice. As far as I remember, all current APIs which return a new pa_operation object only provide a way to subscribe to the result of successful execution. Perhaps I was hoping that, in some future version we can also set up the new callback when created. We can certainly comment out this function for now. However, in the long run, refactoring with this function will help, I think. > * Every new function in the public API need to be added to > src/map-file, otherwise applications won't be able to use the function > (linking will fail). I see. Sorry for the mistake. Favonia
