On Tue, 2012-05-22 at 20:55 -0500, Brian Cameron wrote: > I am attaching 3 patches for consideration upstream: > > - pulseaudio-05-shm.diff > The shm files on Solaris end up with a different name. This patch > makes the code work on Solaris too. > > - pulseaudio-07-sada.diff > Fixes to improve the SunAudio plugin so it works better. > > - pulsaudio-10-endian.diff > On Sparc, WORDS_BIGENDIAN needs to get set if _BIG_ENDIAN is set. Sorry for not replying earlier, I'm working through a pile of unread mail... I've applied the first and third patches. Regarding the second patch, it contains several different fixes - please submit separate patches for separate fixes in the future. I've applied the get_playback_buffered_bytes() and suspend() fixes. About the volume part, is opening the device in sink_set_volume() really necessary, and if it is, shouldn't it be closed too, so that unsuspend() doesn't reopen an already open device? Also, if sink_set_volume() doesn't set exactly the volume that was requested, it should update s->real_volume to contain... well, the real volume. I'd appreciate it if you could send patches using "git send-email" or at least format them with "git format-patch", for easier review and also so that the commits get attributed correctly. -- Tanu
