On Thu, 2013-01-03 at 09:35 -0600, Pierre-Louis Bossart wrote:
> > @@ -48,7 +48,6 @@ PA_MODULE_USAGE(
> > _("sink_name=<name for the sink> "
> > "sink_properties=<properties for the sink> "
> > "master=<name of sink to filter> "
> > - "format=<sample format> "
> > "rate=<sample rate> "
> > "channels=<number of channels> "
> > "channel_map=<channel map> "
> > @@ -77,7 +76,6 @@ static const char* const valid_modargs[] = {
> > "sink_name",
> > "sink_properties",
> > "master",
> > - "format",
> > "rate",
> > "channels",
> > "channel_map",
> What problem are you trying to fix here? It's not obvious why the sample
> format information should be removed, why not the rate and channels
> while we are at it? And even if this is needed, I guess there's dead
> code to parse the argument that should be removed in the _init routine?
The patch title refers to bug 46529, I guess you missed that? Here's the
link: https://bugs.freedesktop.org/show_bug.cgi?id=46529
I hope that makes things clearer. As for removing dead code from
pa__init(), that's not necessary, because the format argument was parsed
by pa_modargs_get_sample_spec_and_channel_map(). There's no dead code to
remove.
--
Tanu
