2012/2/25 Arun Raghavan <arun.raghavan at collabora.co.uk>: > On Fri, 2012-02-24 at 15:39 +0800, Feng Wei wrote: >> Hi David, >> I'm appreciated for your comments. UCM really has a long way to go. > > IMO it's not that bad. While I haven't gone over the code at all, I've > used it on an OMAP4 and it does work (which is pretty neat to see!). > >> 2012/2/24 David Henningsson <david.henningsson at canonical.com>: >> > On 02/21/2012 04:34 AM, Feng Wei wrote: >> >> >> >> Hi Arun, >> >> I'm not clear what should I do to upstream patches. I tested them on >> >> ubuntu, so that I must follow what David had done in port structure. >> >> In my original mind, I will first upstream to ubuntu, then pulseaudio >> >> community. >> >> My current patches are maintained in bzr according to ubuntu, I want >> >> them to be merged in ubuntu branch. >> > >> > >> > Hi Feng, >> > >> > Sorry I haven't responded earlier, but I'm not sure what to do about these >> > patches either. As I see it there are at least three problems that need to >> > be resolved: >> > >> > ?* The competing implementation problem: We've had multiple implementations >> > posted to the PulseAudio mailinglist, one by Janos and Jaska, one by >> > Alejandro and Margarita (probably discontinued?), and one by yourself. It >> > would be great if the UCM community could give us a hint on why we should >> > choose one over another. >> Exactly. Maybe one reason is my patch is the only one to implement the >> agreed concepts mapping between PA and alsa-lib. > > Going by Mark's comments, While it'd be nice to hear from Janos and > Jaska as well, since yours is the only actual code that is available and > being taken forward through the merging process, I think we're fine > going ahead with it. > >> > ?* The patches are based on an older version of PulseAudio - the one that >> > uses the input devices for jack detection. Ubuntu 12.04, as well as >> > PulseAudio 2.0, will release with the new kcontrol jack detection interface >> > [1]. In essence, your patches do not apply, and should we consider these for >> > Ubuntu 12.04 and/or PulseAudio 2.0 we're in quite a hurry. Perhaps it's even >> > too late, I don't know. >> It's really too late. I'll follow the new jack detection method and >> update my patches tho. > > We're trying for much quicker releases now, so missing the 2.0 boat > really isn't catastrophic at all. > > So if you could rebase and send these in a more review-friendly format > (git send-email or a git tree somewhere), that would help move this > forwards. We might have our hands full for a short while getting the > outstanding patches and bugs done for 2.0, but I'd certainly like to try > to get this in for 3.0 (i.e., the next release) if everything looks > good. Surely I will make it in good shape and send the patch again. > > -- Arun > > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss -- Wei.Feng (irc wei_feng) Linaro Multimedia Team Linaro.org???Open source software for ARM SoCs Follow?Linaro:?Facebook?|?Twitter?|?Blog
