On 02/21/2012 04:34 AM, Feng Wei wrote:
> Hi Arun,
> I'm not clear what should I do to upstream patches. I tested them on
> ubuntu, so that I must follow what David had done in port structure.
> In my original mind, I will first upstream to ubuntu, then pulseaudio
> community.
> My current patches are maintained in bzr according to ubuntu, I want
> them to be merged in ubuntu branch.
Hi Feng,
Sorry I haven't responded earlier, but I'm not sure what to do about
these patches either. As I see it there are at least three problems that
need to be resolved:
* The competing implementation problem: We've had multiple
implementations posted to the PulseAudio mailinglist, one by Janos and
Jaska, one by Alejandro and Margarita (probably discontinued?), and one
by yourself. It would be great if the UCM community could give us a hint
on why we should choose one over another.
* The patches are based on an older version of PulseAudio - the one
that uses the input devices for jack detection. Ubuntu 12.04, as well as
PulseAudio 2.0, will release with the new kcontrol jack detection
interface [1]. In essence, your patches do not apply, and should we
consider these for Ubuntu 12.04 and/or PulseAudio 2.0 we're in quite a
hurry. Perhaps it's even too late, I don't know.
* Verification and testing is difficult, for a variety of reasons
(this point is not a real blocker like the other two, just a little
cumbersome):
1) Requires special hardware. I could probably get hold of some
hardware if that was the only thing keeping me from reviewing it though.
2) Requires special configuration files, which are usually kept
private by companies. I assume that the files you have used for imx53
and omap are public though (where can they be found)?
3) I *was* going to complain about the lack of UCM documentation,
but it seems like running "make doc" in alsa-lib 1.0.25 does create a
UCM page (called "case interface"), and while it does not look perfect
everywhere it seems like most things can actually be figured out.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[1] Assuming my recently posted patches pass the review of my fellow
developers on this list :-)
