Coverity warned about an unchecked pa_write() return value, which is fixed in the last patch of this series. While figuring out what pa_mainloop_wakeup() was supposed to do and how it was called, I noticed some other issues related to that function. There's some discussion (so far monologue only) on the mailing list: http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-March/013164.html http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-April/013175.html Tanu Kaskinen (5): mainloop: Change wakeup_requested type from pa_bool_t to pa_atomic_t. mainloop: Remove useless pa_mainloop_wakeup() calls. mainloop: Remove redundant wakeup_pipe validity checks. mainloop: Write to the wakeup pipe unconditionally when waking up the mainloop. mainloop: Check pa_write() return value. src/pulse/mainloop.c | 46 +++++++++++++--------------------------------- 1 files changed, 13 insertions(+), 33 deletions(-) -- 1.7.8
