On 2 April 2012 17:31, Tanu Kaskinen <tanu.kaskinen at digia.com> wrote: > Coverity warned about an unchecked pa_write() return value, > which is fixed in the last patch of this series. While > figuring out what pa_mainloop_wakeup() was supposed to do > and how it was called, I noticed some other issues related > to that function. > > There's some discussion (so far monologue only) on the > mailing list: > http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-March/013164.html > http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-April/013175.html > > Tanu Kaskinen (5): > mainloop: Change wakeup_requested type from pa_bool_t to pa_atomic_t. > mainloop: Remove useless pa_mainloop_wakeup() calls. > mainloop: Remove redundant wakeup_pipe validity checks. > mainloop: Write to the wakeup pipe unconditionally when waking up the > mainloop. > mainloop: Check pa_write() return value. Ack on all, but could you push 1 and 4 to fix bug #56735 now and the rest after 3.0? It would be good to update the documentation to indicate the special status being conferred to pa_mainloop_wakeup() w.r.t. threads (it's implied I guess, but best to be clear about what is and is not kosher across threads). Cheers, Arun
