'Twas brillig, and Maarten Bosmans at 12/09/11 09:37 did gyre and gimble: > 2011/9/1 Colin Guthrie <gmane at colin.guthr.ie>: >>>> 2) If we can eliminate this information from the main thread (empty >>>> brackets or just remove it altogether), that would reduce most of the >>>> log size increased by this patch. >>> >>> On point 2, do you mean "[pulseaudio] xxxx" should be better changed to >>> "[] xxxx" or "xxxx" instead? I agree it's annoying to see lots of >>> "pulseaudio" messages on the log. >>> >>> I can help to make our debugging life easier. :) > > This still needs to be done. Yup, it's in my branch for post-1.0 stuff. I didn't want to mess about with thread related stuff until it's had a bit more testing. >> Just so that work is not duplicated, this is the patch I currently have >> in my "pending" tree for after we reopen master for general feature >> improvements again. > > What's up with the first hunk of thread.h? It's very advanced C code. You wouldn't understand... it's not a typo... honest. :p (will remove it from my tree! - thanks for noticing). > This approach is quite messy, with all the PA_INVALID_INDEX. I'd > rather see the prototypes of pa_thread_* unchanged and just do a > pa_sprintf_malloc in the calling code, where necessary. Well would you do that all the time and pass in a non-const char* or would you require the caller to free? If so then it's a little more work for the caller to implement and thus it may not get done consistently. At least if it's in the API it's quite consistent. I do agree tho', this doing it client side would be more flexible overall, so I'm not against it. I won't touch this patch until after 1.0, so feel free to make it super awesome in the mean time :D Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
