On Sat, Aug 06, 2011 at 07:10:16PM +0800, Colin Guthrie wrote:
> 'Twas brillig, and Pierre-Louis Bossart at 05/08/11 16:24 did gyre and
> gimble:
> >> there're multiple pthreads in pulseuadio, which makes reading a bit
> >> confuse.
> >> this patch can print each pthread's id.
> >
> > Wouldn't it be easier to understand if the thread name was used? We
> > typically rely on thread names to understand what goes on with
> > ftrace/pytimechart, I would think this is similar here. I would rather see a
> > log with "alsa-sink" rather than "PID 6779", it'd also make log comparison
> > and analysis easier.
>
> Yup I agree (in an ideal world we'd name the thread by sink index too...
> (i.e. "alsa-sink 0")
Hi Col,
Do you think it's better to invoke pa_thread_new("alsa-sink 0", func, u)
or adding another index after the plain name? (e.g.
pa_thread_new("alsa-sink", index, func, u))
--
guanqun
