'Twas brillig, and Lu Guanqun at 08/08/11 08:55 did gyre and gimble:
> On Sat, Aug 06, 2011 at 07:10:16PM +0800, Colin Guthrie wrote:
>> 'Twas brillig, and Pierre-Louis Bossart at 05/08/11 16:24 did gyre and
>> gimble:
>>>> there're multiple pthreads in pulseuadio, which makes reading a bit
>>>> confuse.
>>>> this patch can print each pthread's id.
>>>
>>> Wouldn't it be easier to understand if the thread name was used? We
>>> typically rely on thread names to understand what goes on with
>>> ftrace/pytimechart, I would think this is similar here. I would rather see a
>>> log with "alsa-sink" rather than "PID 6779", it'd also make log comparison
>>> and analysis easier.
>>
>> Yup I agree (in an ideal world we'd name the thread by sink index too...
>> (i.e. "alsa-sink 0")
>
> Hi Col,
>
> Do you think it's better to invoke pa_thread_new("alsa-sink 0", func, u)
> or adding another index after the plain name? (e.g.
> pa_thread_new("alsa-sink", index, func, u))
I've not looked at the code, but if we know the sink index by this stage
(I'm not sure we do?) then yes that could be helpful.
Pierre will probably know if this is practically useful tho'. I suppose
in most cases testing and probing will be done with only one sink anyway
so there is no doubt which one owns the thread :p
Col
--
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
